test(wtr): change jasmine globals to explicit imports @W-19098266#5490
Merged
test(wtr): change jasmine globals to explicit imports @W-19098266#5490
Conversation
instead of weird fake module
There's no setup/teardown needed, it's a single test, and WTR provides per-file encapsulation
working toward just importing and executing things, but not quite there yet
two env vars for the same goal is unnecessary
I think the last one was a concurrency related timeout, which was previously addressed.
helper files shouldn't have side effects; all setup should be in the setup file
no longer necessary
all tests are run in isolation
we want to keep the generated wrappers as thin as possible and use regular js files as much as possible
It was originally implemented to suppress distracting warnings in Karma tests, but WTR's log output is different / managed differently.
It breaks hydration tests if there's an import from LWC.
jhefferman-sfdc
approved these changes
Sep 12, 2025
rax-it
approved these changes
Sep 12, 2025
Contributor
Author
|
/nucleus ignore --reason meh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
To make all dependencies more clear/explicit, this PR removes the jasmine globals and replaces them with explicit imports. The jasmine adapters are a consequence of Karma and WTR using different assertion libraries (jasmine vs chai), and should eventually be removed.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item